Updated Autopot to work with Ominous Bottle #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for ominous bottles to the AutoPot module, enabling automatic consumption of Bad Omen effect for raid farm automation. The implementation treats ominous bottles as drinkable items (rather than splash potions) regardless of the splash potion setting.
Changes:
- Added BAD_OMEN to the default list of usable potions
- Modified potion slot detection to recognize and handle ominous bottles
- Updated potion usage logic to correctly drink ominous bottles instead of throwing them
- Reorganized import statements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added support for ominous bottles in AutoPot so it can consume bad omen for raid farms. AutoPot now detects ominous bottles, I have it set to treat them as drinkables even when splash is enabled, which I believe is the best practice for this module based on how it has been implemented (However of course this can be changed)
This change only affects the autopot.java module file
should be a simple PR, if you need anything changed let me know. Wanted to dip my toes into this repo and get familiar with it before fully committing my extended time and effort, so figured this would be a good 20min project to get familiar with the style and code base and etc. I look forward to working together in the future.
Related Issue
Fixes #489
Motivation and Context
AutoPot only accepted regular/splash potion, so ominous bottles were ignored and bad omen couldn’t be auto applied for raid farms.
How Has This Been Tested?
Tested on the most recent build of this and of metor
Added Bad Omen to AutoPot list.
Placed ominous bottles in hotbar.
Enabled AutoPot.
Verified it drinks the ominous bottle.
Verified splash potions still throw correctly when enabled.
Verified drink potions still work correctly when enabled.
made sure to only edit the autopot file.
Types of changes
Bug fix (non-breaking change which fixes an issue)
My code follows the code style of this project.